Don't pass registrationData twice when registering notebook serializer #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
approved these changes
Jul 1, 2021
| displayName: 'Jupyter', | ||
| filenamePattern: ['*.ipynb'] | ||
| }); | ||
| return workspace.registerNotebookSerializer(notebookType, serializer, options); |
There was a problem hiding this comment.
That's odd. Had to spelunk around in vscode core to see why this was an issue. Wonder why that option is even here? https://github.com/microsoft/vscode/blob/7adcbfdd68925543df362b74c7026017d0af3b24/src/vs/workbench/api/browser/mainThreadNotebook.ts#L119
IanMatthewHuff
approved these changes
Jul 1, 2021
joyceerhl
added a commit
that referenced
this pull request
Jul 1, 2021
joyceerhl
added a commit
that referenced
this pull request
Jul 2, 2021
* Don't pass registrationData twice when registering notebook serializer (#6503) * If in Python daily insiders and VS Code Insiders opt into native interactive window (#6504) * If in Python daily insiders and VS Code Insiders opt into native interactive window * Oops * Remove unused import * Changelog * Format
DavidKutu
pushed a commit
that referenced
this pull request
Jul 8, 2021
* prepare release (#6403) * Port jupyter kernel fix to release branch (#6486) * Fix some problems running kernels with 'jupyter' or no raw kernel (#6464) * Fix for 6409 * Jupyter server specific case for kernel data not being used * Update changelog * Fix interactive window debug cell, codelens tracking, go to cell, expand/collapse all from toolbar when focus is not on notebook editor (#6469) (#6493) * fix #6423 * Debug cell fixes * update execution count. * Expand/collapse cell should not rely on `activeNotebookEditor` * Format * Refactor add/debug code codepaths * Prettier Co-authored-by: rebornix <penn.lv@gmail.com> Co-authored-by: rebornix <penn.lv@gmail.com> * enble the debugging setting (#6492) * Port #6503 and #6504 to release (#6507) * Don't pass registrationData twice when registering notebook serializer (#6503) * If in Python daily insiders and VS Code Insiders opt into native interactive window (#6504) * If in Python daily insiders and VS Code Insiders opt into native interactive window * Oops * Remove unused import * Changelog * Format * debugging work (#6505) (#6558) * don't fetch breakpoints on activate * implement IDisposable on the debugging manager * pass on session id's * delete temp files * lint * add try catch * store sessionId * pass jupyter session id * Remove start page in favor of a message (#6576) * prepare release (#6590) * prepare * use same version in package.jpsn and changelog * leave version at 2021.8.0 * publish release * update package-lock Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> Co-authored-by: rebornix <penn.lv@gmail.com> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6501